Cartesian Explosion & N+1 Query on Invoice Pagination
// Anti-pattern: Multiple collection includes without AsSplitQuery() or projection
var query = _dbContext.Invoices
.Include(i => i.LineItems)
.Include(i => i.Discounts)
.Include(i => i.AuditLogs)
.Where(i => i.MerchantId == merchantId)
.OrderByDescending(i => i.CreatedAt);
var total = await query.CountAsync(ct);
var items = await query.Skip((page - 1) * pageSize).Take(pageSize).ToListAsync(ct);// Corrected: Split query, AsNoTracking, and flat projection to DTO
var baseQuery = _dbContext.Invoices
.AsNoTracking()
.Where(i => i.MerchantId == merchantId);
var total = await baseQuery.CountAsync(ct);
var items = await baseQuery
.OrderByDescending(i => i.CreatedAt)
.Skip((page - 1) * pageSize)
.Take(pageSize)
.Select(i => new InvoiceSummaryDto(
i.Id,
i.InvoiceNumber,
i.TotalAmount,
i.Currency,
i.Status,
i.CreatedAt,
i.LineItems.Count
))
.ToListAsync(ct);- ✔Apply .AsNoTracking() to eliminate Entity Framework change-tracker overhead on read operations.
- ✔Enable .AsSplitQuery() to decouple collection joins into independent, optimized SQL queries when graphs are needed.
- ✔Project directly into an InvoiceSummaryDto to retrieve only the fields required by the frontend grid.